From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,
	REPLYTO_WITHOUT_TO_CC autolearn=no autolearn_force=no version=3.4.4
Path: 
 eternal-september.org!reader01.eternal-september.org!reader02.eternal-september.org!news.eternal-september.org!mx02.eternal-september.org!feeder.eternal-september.org!aioe.org!.POSTED!not-for-mail
From: "Dmitry A. Kazakov" <mailbox@dmitry-kazakov.de>
Newsgroups: comp.lang.ada
Subject: Re: Problem with Unbounded Strings
Date: Fri, 4 Dec 2015 23:23:50 +0100
Organization: cbb software GmbH
Message-ID: <3t2zcznh7x3c$.1gg5z5cxi63r3.dlg@40tude.net>
References: <e28c35a7-5f41-4beb-afb3-eb4fc9da9384@googlegroups.com>
 <17lytwwdndg6u.1o21jn6ox2sd4$.dlg@40tude.net>
 <2c489db5-0d14-4a1e-9883-cf018c3a0b83@googlegroups.com>
 <19i08yxoly6r5.lk9snum67ier.dlg@40tude.net>
 <f29cf0ba-c0a4-4b85-8a2a-6533750d08f0@googlegroups.com>
Reply-To: mailbox@dmitry-kazakov.de
NNTP-Posting-Host: Sfz0eNwKWh4Uq03iti+GMw.user.speranza.aioe.org
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Complaints-To: abuse@aioe.org
User-Agent: 40tude_Dialog/2.0.15.1
X-Notice: Filtered by postfilter v. 0.8.2
Xref: news.eternal-september.org comp.lang.ada:28647
Date: 2015-12-04T23:23:50+01:00
List-Id: <comp.lang.ada>

On Fri, 4 Dec 2015 13:43:22 -0800 (PST), Laurent wrote:

> On Friday, 4 December 2015 21:34:59 UTC+1, Dmitry A. Kazakov  wrote:
>> On Fri, 4 Dec 2015 08:53:54 -0800 (PST), in comp.lang.ada you wrote:
>> 
>>> I don't use append?
>> 
>> No. There is nothing that is not in the buffer read already. Why would you
>> append anything?
>> 
>> In some protocols payload data are accumulated from several packets.
>> Unbounded_String is not used for that either. You want to limit the size of
>> the accumulated data to prevent DoS attacks unless the protocol limits that
>> already, as most protocols do. Simply keep the buffer in the communication
>> object, that is all.
> 
> DoS attacks? Why should I care in this case.

Corrupt files?

> I use the Unbounded Strings because I don't know in advance how many lines
> the message will be long. So I collect everything in a buffer, appending
> the following lines, so that it makes sense and when the message is
> complete, feed it to next procedure which slices of the interesting parts
> and uses them to generate a message object which I store somewhere or
> whatever if I should ever get so far.

No, the strategy is to pass lines or other parts of the message further
instead of accumulating it in the memory. Instead of this "hamster" design
I would do something like:

type Log_Parser
     (  Stream : not null access Root_Stream_Type'Class;
        Size : Positive
     )  is new Ada.Finalization.Limited_Controlled with
record
   Buffer : String (1..Size); -- Input is accumulated here
   Last : Natural; -- Current message line last character in Line_Buffer
   Stamp : Time; -- Current message's time stamp
   Line_No : Positive; -- Current message's line number
   ...
end record;

function Get_Line (Source : not null access Log_Parser) return String;
   -- reads from stream and returns Source.Buffer (1..Source.Last)

This will work with files as well. The client will call Get_Line for each
message line.

-- 
Regards,
Dmitry A. Kazakov
http://www.dmitry-kazakov.de