Re: I'm facing an issue with: call to abstract procedure must be dispatching

["Randy Brukardt" <randy@rrsoftware.com>]

"Jeffrey R. Carter" <spam.jrcarter.not@spam.not.acm.org> wrote in message 
news:n47n08$3tr$1@dont-email.me...
> On 12/08/2015 03:43 PM, Serge Robyns wrote:
>>
>> Now I've a generic question with regards to access type vs. in-out for 
>> parameters.  What is the proper Ada way to pass the "Store" around?
>> Is it:
>> Procedure Do_Something (A_Store : in out T_Abstract_Store'Class);
>> or:
>> Procedure Do_Something (A_Store : not null access 
>> T_Abstract_Store'Class);
>> ?
>>
>> As a former C programmer my habit goes for the not null access variant.
>
> As an Ada S/W engineer, you should use "in out". With "in out", the 
> compiler
> does the work of passing the object in such a way that the operation can 
> read
> and modify the value. With an access, you (or whoever calls your 
> operation) has
> to do extra work to have an access value to pass. It's unnecessary extra 
> work
> and an extra chance to get something wrong, and so to be avoided.

On top of which, it tends to limit how the client can use your package. In 
particular, the client most likely couldn't put values of your object type 
into a container, because Ada puts very strict limits on getting an access 
value into a container. (Additionally, because of the extra runtime 
accessibility checking, the access version is slower. That effect is small 
enough that it shouldn't be a major determining factor in deciding which to 
use, but if all other things are equal, why would anyone want to use the 
slower version??)

                                         Randy.