From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on polar.synack.me
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00
	autolearn=unavailable autolearn_force=no version=3.4.4
Path: 
 eternal-september.org!reader01.eternal-september.org!reader02.eternal-september.org!news.eternal-september.org!mx02.eternal-september.org!.POSTED!not-for-mail
From: "Jeffrey R. Carter" <spam.jrcarter.not@spam.not.acm.org>
Newsgroups: comp.lang.ada
Subject: Re: I'm facing an issue with: call to abstract procedure must be
 dispatching
Date: Sun, 13 Dec 2015 19:20:36 -0700
Organization: Also freenews.netfront.net; news.tornevall.net;
 news.eternal-september.org
Message-ID: <n4l8sv$jk0$1@dont-email.me>
References: <8bc7fd76-f00a-4eea-9715-470af028fc84@googlegroups.com>
 <1krm4xun4e4ny.jmh9kvf6s0a9.dlg@40tude.net>
 <12dc7aea-933d-4271-95bd-10df808917e4@googlegroups.com>
 <5hfb2q9imjfu.zs3xp9gxw0d3.dlg@40tude.net>
 <5788b259-8886-4ee2-8c3d-7799abfd840e@googlegroups.com>
 <rt3n7ox7u8lf$.1me9jljeld3bs$.dlg@40tude.net>
 <14acd8b0-a5e9-40fd-b7cc-d319f914d507@googlegroups.com>
 <n47n11$3tr$2@dont-email.me>
 <d674e44a-6341-4f73-903f-4bcee8406912@googlegroups.com>
 <2b70cc02-600e-4f4e-b6fe-86d7e01648ef@googlegroups.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Injection-Date: Mon, 14 Dec 2015 02:18:09 -0000 (UTC)
Injection-Info: mx02.eternal-september.org;
 posting-host="caa759af2a9c666aec02942f6fe5abd6";
	logging-data="20096"; mail-complaints-to="abuse@eternal-september.org";
	posting-account="U2FsdGVkX1/oH4sxSwvDEG0sVq0oyV9nU3ND+TsNi1k="
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
In-Reply-To: <2b70cc02-600e-4f4e-b6fe-86d7e01648ef@googlegroups.com>
X-Mozilla-News-Host: news://freenews.netfront.net
Cancel-Lock: sha1:V4BRdYqFhlnogFGkkVJtFojQqQg=
Xref: news.eternal-september.org comp.lang.ada:28804
Date: 2015-12-13T19:20:36-07:00
List-Id: <comp.lang.ada>

On 12/13/2015 02:37 PM, Shark8 wrote:
> 
> Package Counter is
>   Procedure Inc;
>   Procedure Dec;
>   Function Value Return Natural;
> Private
>   Data : Natural := 0;
> End Counter;

I wouldn't put the state in the private part.

> Package Body Counter is

Instead, I'd put it in the body

   Data : Natural := 0;

>   Procedure Inc is
>   begin
>    Data:= Natural'Succ( Data );
>   end Inc;
> 
>   Procedure Dec is
>   begin
>    Data:= Natural'Pred( Data );
>   end Dec;

I'd also use "+ 1" or "- 1", since those are clearer.

>   Function Value return Natural is
>   ( Data );
> End Counter;

-- 
Jeff Carter
"I don't know why I ever come in here. The
flies get the best of everything."
Never Give a Sucker an Even Break
102