GNAT CE 2019 bug: Predicate check not performed

GNAT CE 2019 bug: Predicate check not performed

[AdaMagica]

The problem is with GNAT CE 2019.
GNAT CE 2018 was correct.
------------------------------------------------
with Ada.Text_IO;
use  Ada.Text_IO;
with Ada.Assertions;
use  Ada.Assertions;

procedure Ass is

  pragma Assertion_Policy (Check);

  subtype String_5 is String with Dynamic_Predicate => String_5'First = 5;

  procedure P (X: String_5) is
  begin
    Put_Line ("P expects 5:" & X'First'Image);
  end P;

  procedure Q (X: String) is
  begin
    P (X);  -- Why no predicate check here?
  end Q;

  S: constant String := "Lady Ada";

begin

  begin
    Q (S);  -- prints 1, expected Assertion_Error
    Put_Line ("Problem Q: Assertion_Error not raised.");
  exception
    when Assertion_Error => Put_Line ("Q: Assertion_Error raised as expected.");
  end;

  begin
    P (S);  -- Assertion_Error raised here
    Put_Line ("Problem P: Assertion_Error not raised.");
  exception
    when Assertion_Error => Put_Line ("P: Assertion_Error raised as expected.");
  end;

end Ass;
---------------------
Result GNAT CE 2018
C:\Users\Grein\Documents\Christoph\Ada\Spielplatz\ausprobieren.exe
Q: Assertion_Error raised as expected.
P: Assertion_Error raised as expected.
[2020-04-18 19:33:34] process terminated successfully, elapsed time: 07.47s
Result GNAT CE 2019
C:\Users\Grein\Documents\Christoph\Ada\Spielplatz\ausprobieren.exe
P expects 5: 1
Problem Q: Assertion_Error not raised.
P: Assertion_Error raised as expected.
[2020-04-18 19:58:20] process terminated successfully, elapsed time: 04.25s

Re: GNAT CE 2019 bug: Predicate check not performed

[Anh Vo]

On Sunday, April 19, 2020 at 2:28:18 AM UTC-7, AdaMagica wrote:
> The problem is with GNAT CE 2019.
> GNAT CE 2018 was correct.
> ------------------------------------------------
> with Ada.Text_IO;
> use  Ada.Text_IO;
> with Ada.Assertions;
> use  Ada.Assertions;
> 
> procedure Ass is
> 
>   pragma Assertion_Policy (Check);
> 
>   subtype String_5 is String with Dynamic_Predicate => String_5'First = 5;
> 
>   procedure P (X: String_5) is
>   begin
>     Put_Line ("P expects 5:" & X'First'Image);
>   end P;
> 
>   procedure Q (X: String) is
>   begin
>     P (X);  -- Why no predicate check here?
>   end Q;
> 
>   S: constant String := "Lady Ada";
> 
> begin
> 
>   begin
>     Q (S);  -- prints 1, expected Assertion_Error
>     Put_Line ("Problem Q: Assertion_Error not raised.");
>   exception
>     when Assertion_Error => Put_Line ("Q: Assertion_Error raised as expected.");
>   end;
> 
>   begin
>     P (S);  -- Assertion_Error raised here
>     Put_Line ("Problem P: Assertion_Error not raised.");
>   exception
>     when Assertion_Error => Put_Line ("P: Assertion_Error raised as expected.");
>   end;
> 
> end Ass;
> ---------------------
> Result GNAT CE 2018
> C:\Users\Grein\Documents\Christoph\Ada\Spielplatz\ausprobieren.exe
> Q: Assertion_Error raised as expected.
> P: Assertion_Error raised as expected.
> [2020-04-18 19:33:34] process terminated successfully, elapsed time: 07.47s
> Result GNAT CE 2019
> C:\Users\Grein\Documents\Christoph\Ada\Spielplatz\ausprobieren.exe
> P expects 5: 1
> Problem Q: Assertion_Error not raised.
> P: Assertion_Error raised as expected.
> [2020-04-18 19:58:20] process terminated successfully, elapsed time: 04.25s

It takes time to look thru the LRM to if this behavior is expected or not. However if String_5 is changed to type and lines 19 and 34 are adjusted for compilation, then it behaves as in GNAT CE 2018. By the way, GNAT Community 2019 on Windows 10 is for this check.

Re: GNAT CE 2019 bug: Predicate check not performed

[Anh Vo]

On Sunday, April 19, 2020 at 3:31:15 PM UTC-7, Anh Vo wrote:
> On Sunday, April 19, 2020 at 2:28:18 AM UTC-7, AdaMagica wrote:
> > The problem is with GNAT CE 2019.
> > GNAT CE 2018 was correct.
> > ------------------------------------------------
> > with Ada.Text_IO;
> > use  Ada.Text_IO;
> > with Ada.Assertions;
> > use  Ada.Assertions;
> > 
> > procedure Ass is
> > 
> >   pragma Assertion_Policy (Check);
> > 
> >   subtype String_5 is String with Dynamic_Predicate => String_5'First = 5;
> > 
> >   procedure P (X: String_5) is
> >   begin
> >     Put_Line ("P expects 5:" & X'First'Image);
> >   end P;
> > 
> >   procedure Q (X: String) is
> >   begin
> >     P (X);  -- Why no predicate check here?
> >   end Q;
> > 
> >   S: constant String := "Lady Ada";
> > 
> > begin
> > 
> >   begin
> >     Q (S);  -- prints 1, expected Assertion_Error
> >     Put_Line ("Problem Q: Assertion_Error not raised.");
> >   exception
> >     when Assertion_Error => Put_Line ("Q: Assertion_Error raised as expected.");
> >   end;
> > 
> >   begin
> >     P (S);  -- Assertion_Error raised here
> >     Put_Line ("Problem P: Assertion_Error not raised.");
> >   exception
> >     when Assertion_Error => Put_Line ("P: Assertion_Error raised as expected.");
> >   end;
> > 
> > end Ass;
> > ---------------------
> > Result GNAT CE 2018
> > C:\Users\Grein\Documents\Christoph\Ada\Spielplatz\ausprobieren.exe
> > Q: Assertion_Error raised as expected.
> > P: Assertion_Error raised as expected.
> > [2020-04-18 19:33:34] process terminated successfully, elapsed time: 07.47s
> > Result GNAT CE 2019
> > C:\Users\Grein\Documents\Christoph\Ada\Spielplatz\ausprobieren.exe
> > P expects 5: 1
> > Problem Q: Assertion_Error not raised.
> > P: Assertion_Error raised as expected.
> > [2020-04-18 19:58:20] process terminated successfully, elapsed time: 04.25s
> 
> It takes time to look thru the LRM to if this behavior is expected or not. However if String_5 is changed to type and lines 19 and 34 are adjusted for compilation, then it behaves as in GNAT CE 2018. By the way, GNAT Community 2019 on Windows 10 is for this check.

It takes time to look thru the LRM to see if...

Re: GNAT CE 2019 bug: Predicate check not performed

[AdaMagica]

Am Montag, 20. April 2020 00:32:37 UTC+2 schrieb Anh Vo:
> It takes time to look thru the LRM to see if...

RM 11.4.2(10.2/3) ... A pragma Assertion_Policy given in a declarative_part or ... applies from the place of the pragma to the end of the innermost enclosing declarative region. ...

Re: GNAT CE 2019 bug: Predicate check not performed

[Anh Vo]

On Monday, April 20, 2020 at 3:04:47 AM UTC-7, AdaMagica wrote:
> Am Montag, 20. April 2020 00:32:37 UTC+2 schrieb Anh Vo:
> > It takes time to look thru the LRM to see if...
> 
> RM 11.4.2(10.2/3) ... A pragma Assertion_Policy given in a declarative_part or ... applies from the place of the pragma to the end of the innermost enclosing declarative region. ...

I read this section and other related paragraphs. I could not any where that confirms this behavior. Therefore, I would suggest to send a bug report to report@adacore.com. 
 

Re: GNAT CE 2019 bug: Predicate check not performed

[AdaMagica]

Am Montag, 20. April 2020 22:25:23 UTC+2 schrieb Anh Vo:
> Therefore, I would suggest to send a bug report

I did, but since I'm not a supported customer, I won't get an answer.

Re: GNAT CE 2019 bug: Predicate check not performed

[Anh Vo]

On Monday, April 20, 2020 at 5:53:42 PM UTC-7, AdaMagica wrote:
> Am Montag, 20. April 2020 22:25:23 UTC+2 schrieb Anh Vo:
> > Therefore, I would suggest to send a bug report
> 
> I did, but since I'm not a supported customer, I won't get an answer.

Just use the work around by making String_5 as a new type of String (type String_5 is new String...). I am not sure if the fix will be in GNAT Community 2020 since this bug report is not early enough. It would be terrific if it is included in the upcoming release of GNAT Community 2020.

Re: GNAT CE 2019 bug: Predicate check not performed

[Per Sandberg]

Just tested with the latest supported GNAT and its fixed.
/P

On 4/21/20 2:53 AM, AdaMagica wrote:
> Am Montag, 20. April 2020 22:25:23 UTC+2 schrieb Anh Vo:
>> Therefore, I would suggest to send a bug report
> 
> I did, but since I'm not a supported customer, I won't get an answer.
> 

Re: GNAT CE 2019 bug: Predicate check not performed

[AdaMagica]

Am Dienstag, 21. April 2020 07:14:32 UTC+2 schrieb Per Sandberg:
> Just tested with the latest supported GNAT and its fixed.
> /P

I doubt it's fixed because of my report, too recent. But let's hope it will be correct again in GNAT CE 2020.

Re: GNAT CE 2019 bug: Predicate check not performed

[Simon Wright]

AdaMagica <christ-usch.grein@t-online.de> writes:

> Am Montag, 20. April 2020 22:25:23 UTC+2 schrieb Anh Vo:
>> Therefore, I would suggest to send a bug report
>
> I did, but since I'm not a supported customer, I won't get an answer.

I'm no supported, and I've had answers.

Re: GNAT CE 2019 bug: Predicate check not performed

[Simon Wright]

Anh Vo <anhvofrcaus@gmail.com> writes:

>  I am not sure if the fix will be in GNAT Community 2020 since this
> bug report is not early enough. It would be terrific if it is included
> in the upcoming release of GNAT Community 2020.

It's not fixed in FSF GCC 10 (as of gcc version 10.0.1 20200206; no
obviously-related changes since then)

Re: GNAT CE 2019 bug: Predicate check not performed

[Per Sandberg]

I tested against the 21.0w-20200305 version.
/P

On 4/21/20 9:34 AM, AdaMagica wrote:
> Am Dienstag, 21. April 2020 07:14:32 UTC+2 schrieb Per Sandberg:
>> Just tested with the latest supported GNAT and its fixed.
>> /P
> 
> I doubt it's fixed because of my report, too recent. But let's hope it will be correct again in GNAT CE 2020.
> 

Re: GNAT CE 2019 bug: Predicate check not performed

[Optikos]

On Tuesday, April 21, 2020 at 2:40:13 AM UTC-5, Simon Wright wrote:
> AdaMagica <christ-usch.grein@t-online.de> writes:
> 
> > Am Montag, 20. April 2020 22:25:23 UTC+2 schrieb Anh Vo:
> >> Therefore, I would suggest to send a bug report
> >
> > I did, but since I'm not a supported customer, I won't get an answer.
> 
> I'm no supported, and I've had answers.

You effectively provide Mac support/service to GNAT.  You are not developing a directly or indirectly competing Ada-language nonGNAT product.  I am pretty sure that is why.

Re: GNAT CE 2019 bug: Predicate check not performed

[William J. Franck]

On 2020-04-21 07:45:52 +0000, Simon Wright said:

> 
> It's not fixed in FSF GCC 10 (as of gcc version 10.0.1 20200206; no
> obviously-related changes since then)


Still not fixed in FSF gcc 10 master branch as on 2020-04-21

$ gnat -version
GNAT 10.0.1 20200421 (experimental)
Copyright 1996-2020, Free Software Foundation, Inc.

on MacOS 10.14.6

$./ass
P expects 5: 1
Problem Q: Assertion_Error not raised.
P: Assertion_Error raised as expected.