Detect arithmetic operator usage for user-defined integer type

Detect arithmetic operator usage for user-defined integer type

[gautier_niouzes]

In a project I'm reworking, there is a type

  type Opcode is range 0 .. 79;

associated with values:

  k_Load_Address                  : constant := 0;
  k_Push_Value                    : constant := 1;
  ...

I'd like to define Opcode as an enumerated type:

  type Opcode is (k_Load_Address, k_Push_Value, ...);

The problem is that there are, in some places in the legacy code, arithmetic operations on Opcode values (ouch!). Is there a tool able to list those operations for the custom type Opcode, other than defining Opcode as enumerated and let the compiler find the arithmetic operations to be removed? Probably it's what I'll do ultimately, but maybe such a detection could be useful in another context.

TIA
_________________________ 
Gautier's Ada programming 
http://gautiersblog.blogspot.com/search/label/Ada 
NB: follow the above link for a valid e-mail address 

Re: Detect arithmetic operator usage for user-defined integer type

[Dmitry A. Kazakov]

On 2020-04-16 12:07, gautier_niouzes@hotmail.com wrote:
> In a project I'm reworking, there is a type
> 
>    type Opcode is range 0 .. 79;
> 
> associated with values:
> 
>    k_Load_Address                  : constant := 0;
>    k_Push_Value                    : constant := 1;
>    ...
> 
> I'd like to define Opcode as an enumerated type:
> 
>    type Opcode is (k_Load_Address, k_Push_Value, ...);
> 
> The problem is that there are, in some places in the legacy code, arithmetic operations on Opcode values (ouch!). Is there a tool able to list those operations for the custom type Opcode, other than defining Opcode as enumerated and let the compiler find the arithmetic operations to be removed? Probably it's what I'll do ultimately, but maybe such a detection could be useful in another context.

You could define your own "+" on Opcode, recompile in GPS, and then 
"find all references" on "+". That should list it.

-- 
Regards,
Dmitry A. Kazakov
http://www.dmitry-kazakov.de

Re: Detect arithmetic operator usage for user-defined integer type

[gautier_niouzes]

> You could define your own "+" on Opcode, recompile in GPS, and then 
> "find all references" on "+". That should list it.

Perfect - was the right idea! Thanks!

BTW, the result is there (file hac-pcode.ads): https://sf.net/p/hacadacompiler/code/128/#diff-4